Add support for hiera-eyaml-gkms #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkubaczyk
pushed a commit
that referenced
this pull request
Aug 18, 2023
* Add support for hiera-eyaml-gkms * Add hiera-eyaml-gkms to Dockerifle --------- Co-authored-by: Rafal Jendraszak <rjendraszak@egnyte.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed, that helmsman supports
hiera-eyamlwith only local PKCS7 keys for secrets. This PR adds support for Google Cloud KMS inhiera-eyaml.Currently, helmsman only supports
hiera-eyamlwith local PKCS7 keys for secrets. This limits users who want to manage their keys differently.I have made a code changes to add support for
hiera-eyaml-gkms, which is a plugin forhiera-eyamlthat extends defaulthiera-eyamlfunctionalities. This will allow users to encrypt and decrypt secrets using GKMS keys stored in GCP. Users can specify the project id, keyring and crypto-key they are referring to.These change will add a valuable feature to helmsman allowing users to use different method and can be a starting point to include also different cloud providers for
heira-eyaml.