forked from openshift/installer
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
libvirt: support setting network dnsmasq options through the install …
…config Since libvirt 5.6.0, there is an option to pass in dnsmasq options through the libvirt network [1]. Leveraging this would be useful for the multi-arch automation as we have a hacky workaround today to inject host records [2] which waits for the libvirt network to be created and then updates it with the records (which is need in libvirt because of [3]). With this dnsmasq option which can be specified in the libvirt network at creation time, we can point to the .1 address and have a load balancer forward the traffic which would be much cleaner. With this change, the option can be specified through the install config yaml in the network section as pairs of option name and values. An example: ``` platform: libvirt: network: dnsmasqoptions: address: "/.apps.tt.testing/192.168.126.51" if: tt0 ``` The terraform provider supports rendering these options through a datasource and injecting them into the network xml. Since this config is optional, not specifying it will continue to work as before without issues. [1] https://libvirt.org/formatnetwork.html#elementsNamespaces [2] https://github.com/openshift/release/blob/master/ci-operator/templates/openshift/installer/cluster-launch-installer-remote-libvirt-e2e.yaml#L498 [2] openshift#1007
- Loading branch information
1 parent
590ec43
commit 3b59bb4
Showing
3 changed files
with
55 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters