Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Adds porting of network configuration to generated base job templates #392

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Mar 6, 2024

Updates generate_work_pool_base_job_template to include network configuration customizations when publishing an ECSTask as a work pool.

Adds some utilities for generating minimal documents to use with the JSON patches configured on a block.

Closes #386

Example

Screenshots

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.

@desertaxle desertaxle requested a review from a team as a code owner March 6, 2024 18:57
Copy link
Contributor

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@desertaxle desertaxle merged commit 72c106f into main Mar 6, 2024
6 checks passed
@desertaxle desertaxle deleted the migrate-network-configuration branch March 6, 2024 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECSTask block publish_as_work_pool does not set network_configuration
2 participants