This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Support for capacity provider #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
reviewed
Apr 4, 2024
…m/PrefectHQ/prefect-aws into improvement/add-capacity-provider
This reverts commit 0bea3e7.
kevingrismore
approved these changes
Apr 11, 2024
prefect_aws/workers/ecs_worker.py
Outdated
| @@ -267,6 +278,7 @@ class ECSJobConfiguration(BaseJobConfiguration): | |||
| auto_deregister_task_definition: bool = Field(default=False) | |||
| vpc_id: Optional[str] = Field(default=None) | |||
| container_name: Optional[str] = Field(default=None) | |||
|
|
|||
prefect_aws/workers/ecs_worker.py
Outdated
| default_factory=list, | ||
| description=( | ||
| "The capacity provider strategy to use when running the task. This is only" | ||
| "If a capacityProviderStrategy is specified, we will omit the launchType" |
There was a problem hiding this comment.
"The capacity provider strategy to use when running the task. "
"If a capacity provider strategy is specified, the selected launch type will be ignored."
prefect_aws/workers/ecs_worker.py
Outdated
| # Should not be provided at all if capacityProviderStrategy is set, see https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_RunTask.html#ECS-RunTask-request-capacityProviderStrategy # noqa | ||
| self._logger.warning( | ||
| "Removing launchType from task run request. Due to finding" | ||
| " capacityProviderStrategy in the request." |
There was a problem hiding this comment.
"Found capacityProviderStrategy. "
"Removing launchType from task run request."
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables passing down
capacityProviderStrategytotask_run_request.Closes #362
Checklist
pre-commitchecks.pre-commit install && pre-commit run --alllocally for formatting and linting.mkdocs serveview documentation locally.