Adds option to specify workPool #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkedwards
previously approved these changes
Feb 27, 2023
EmilRex
changed the title
EmilRex
changed the title
jimid27
dismissed stale reviews from parkedwards, jamiezieziula, and themself
via
9f2f1e3
|
this would be super helpful to me |
|
Hey y'all, I tested out the chart locally. I pulled down Emil's chart and deployed the agent on minikube. I ended up hardcoding the work pool for the sake of testing, but it was able to deploy the agent successfully. @EmilRex If you can sync sometime I can show you how I tested the chart |
EmilRex
requested review from
jimid27,
parkedwards and
jamiezieziula
and removed request for
jimid27 and
parkedwards
|
Alright... I made (and tested) some changes to the default behavior. Now if neither @jimid27 Does that make sense to you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds option to set a single
workPoolin chart.Still need to test the change to verify that existing behavior isn't changed and new behavior is.