chore(prometheus-prefect-exporter): Add additionalLabels for serviceMonitor #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks good, thanks for the contribution!
Just wondering if we should update these files so the new configuration is documented and validated:
- https://github.com/PrefectHQ/prefect-helm/blob/main/charts/prometheus-prefect-exporter/README.md
- https://github.com/PrefectHQ/prefect-helm/blob/main/charts/prometheus-prefect-exporter/values.schema.json
@jamiezieziula - would you prefer these to be updated before merging this?
|
@mitchnielsen good point! @hlac9x can you install and run pre-commit locally? This should update the readme for you, but you'll need to manually adjust the values schema. Thanks! |
|
@mitchnielsen @jamiezieziula . The README and validate file is updated pre request |
jamiezieziula
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This PR aims to enhance the ServiceMonitor configuration for the prometheus-prefect-exporter by introducing the ability to add custom labels through the additionalLabels field. This change is crucial for ensuring that the ServiceMonitor can be properly managed and identified by Prometheus, particularly in environments where specific labeling is required for integration or management purposes.
Key Changes:
Introduction of
additionalLabels: The updated ServiceMonitor configuration now includes an option to add custom labels specified by.Values.serviceMonitor.additionalLabels. This allows users to define additional labels in their Helm values, which will be incorporated into the ServiceMonitor metadata.Issue Addressed:
The previous configuration did not support the addition of custom labels, which limited the ability to manage the ServiceMonitor effectively within Prometheus environments that require specific labeling conventions. This update resolves that issue by providing the necessary flexibility for label customization.
This change ensures that users can now easily add the necessary custom labels to their ServiceMonitor, facilitating better integration and management with Prometheus.