Change postgresql.useSubChart to .enabled

[mitchnielsen]

Summary

Changes postgresql.useSubChart to postgresql.enabled, following the common convention mentioned in https://helm.sh/docs/topics/charts/https://helm.sh/docs/topics/charts/.

This should hopefully make it clearer what that key does - and this key already existed, so by removing useSubChart, there's only one key to manipulate.

Other commits in this PR have commit messages explaining what and why.

Closes #336

Testing

Internal PostgreSQL enabled (default)

(Default values used)

$ helm template test . -f test.values.yaml --show-only charts/postgresql/templates/primary/statefulset.yaml | yq '.metadata.name'
test-postgresql

Internal PostgreSQL disabled

postgresql:
  enabled: false

$ helm template test . -f test.values.yaml --show-only charts/postgresql/templates/primary/statefulset.yaml | yq '.metadata.name'
Error: could not find template charts/postgresql/templates/primary/statefulset.yaml in chart
null

Internal PostgreSQL + default Secret

(Default values used)

$ helm template test . -f test.values.yaml --show-only templates/deployment.yaml| yq '.spec.template.spec.containers[0].env[] | select(.name == "PREFECT_API_DATABASE_CONNECTION_URL") | .valueFrom.secretKeyRef.name'
prefect-server-postgresql-connection

Internal PostgreSQL + existing Secret

postgresql:
  enabled: true
  auth:
    existingSecret: my-external-pg-secret

$ helm template test . -f test.values.yaml --show-only templates/deployment.yaml| yq '.spec.template.spec.containers[0].env[] | select(.name == "PREFECT_API_DATABASE_CONNECTION_URL") | .valueFrom.secretKeyRef.name'
my-external-pg-secret

External PostgreSQL + existing Secret

postgresql:
  enabled: false
  auth:
    existingSecret: my-external-pg-secret

$ helm template test . -f test.values.yaml --show-only templates/deployment.yaml| yq '.spec.template.spec.containers[0].env[] | select(.name == "PREFECT_API_DATABASE_CONNECTION_URL") | .valueFrom.secretKeyRef.name'
my-external-pg-secret

[mitchnielsen]

Jotting down action items for myself:

Caught up with @jamiezieziula on this. The postgresql.auth key in values.yaml is Prefect-specific, so we need to allow auth settings to be set outside of the scope of postgresql when the built-in PG chart isn't used (postgresql.enabled=false).

We'll also want to support passing no auth and no database for those who want to test with the SQLite DB.

---

EDIT: following up here, you can still pass values to the postgresql.auth key even when postgresql.enabled=false and we'll still consider the values there. This is because we no longer check if postgresql.enabled=true when injecting the Secret into the Deployment (31c8577). The name of that Secret is calculated by a helper which will consider auth.existingSecret if specified.

[jamiezieziula]

There is a duplicate enabled map in the json schema. Also, can you remove all form: true fields in the schema, these aren't needed (we removed most before but must have missed these)

[mitchnielsen]

Removed form fields from the server schema in 88262c8.

[mitchnielsen]

• Failures seem to be from hitting the Docker pull limit.
• Will proceed with merge soon but wanted to give the community member a chance to chime in.
• Will also consider if this could be a breaking change 🤔
  • It shouldn't be. Those who were using useSubChart can remove it, as that key is no longer considered. The existing key enabled now does what users expect it should do.

[pythonking6]

This is excellent!!!