[New engine] Syncify flow engine #13246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cicdw
reviewed
May 5, 2024
| @@ -458,3 +458,23 @@ async def run_task_async( | |||
| if return_type == "state": | |||
| return run.state | |||
| return run.result() | |||
|
|
|||
|
|
|||
| def run_task( | |||
cicdw
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister PR to #13234
This PR uses the Starlette test client for synchronous ephemeral API access. I tried a variety of approaches, including running the ASGI app in a background thread, but all created occasional and odd issues with deadlocks in CI. Ultimately this approach is simple, straightforward, and works well.
I did have to port a one-line bugfix (encode/starlette#2376) into our vendored code for how the TestClient joins URLs to the base URL, as it was dropping the
/apisuffix and failing to resolve.Temporarily disables new engine tests on
tests/tasks.pywhile we work through taskrunners.