-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow JSON values in Secret
block
#14980
Conversation
005281c
to
b21d865
Compare
CodSpeed Performance ReportMerging #14980 will not alter performanceComparing Summary
|
ab68afc
to
d3bc0e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a manual sanity check, I want to test a load against an "old" secret stored somewhere but otherwise this LGTM
b792e22
to
af2f0f7
Compare
coming back to this, I've checked this against all the old secrets I've had defined before - have you found any cases of unexpected behavior? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two nits on docstring changes, but otherwise LGTM!
85b4d4a
to
e8ba752
Compare
this PR closes #14899 by allowing any
JSON
value (i.e. strings, lists, dictionaries) to be stored as a secretexamples
this PR should not change any behavior for current users of
Secret
, including this outstanding issue about stripping newlines