Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prefect dashboard open to open dashboard from CLI #14985

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Aug 17, 2024

follow up to #11519

this PR moves prefect cloud open to prefect dashboard open so that it can also coherently support opening the oss dashboard

Copy link

codspeed-hq bot commented Aug 17, 2024

CodSpeed Performance Report

Merging #14985 will not alter performance

Comparing prefect-server-open (1a73ede) with main (d867dd0)

Summary

✅ 4 untouched benchmarks

@zzstoatzz zzstoatzz marked this pull request as ready for review August 17, 2024 16:23
@desertaxle
Copy link
Member

Could prefect cloud open and prefect server open be consolidated under prefect dashboard open?

@zzstoatzz
Copy link
Collaborator Author

Could prefect cloud open and prefect server open be consolidated under prefect dashboard open?

yeah it could if you think that'd be better, i just figured i'd keep the current subgroups and pattern. i don't feel strongly

@desertaxle
Copy link
Member

Yeah, I think it'd be a better UX if there were only one command. Then, the user doesn't need to change which command to run based on their current profile.

@zzstoatzz zzstoatzz force-pushed the prefect-server-open branch from 96ee6a4 to 1a73ede Compare August 26, 2024 16:40
@zzstoatzz zzstoatzz changed the title add prefect server open to open dashboard from CLI add prefect dashboard open to open dashboard from CLI Aug 26, 2024
@zzstoatzz zzstoatzz merged commit 491af65 into main Aug 26, 2024
32 checks passed
@zzstoatzz zzstoatzz deleted the prefect-server-open branch August 26, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants