Remove CausalOrdering from task-run-recorder
#15244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakekaplan
requested review from
cicdw,
desertaxle and
zzstoatzz
as code owners
chrisguidry
approved these changes
Sep 5, 2024
| record_task_run_event_mock.assert_awaited_with(event) | ||
| @pytest.mark.parametrize( | ||
| "event_order", | ||
| list(permutations(["PENDING", "RUNNING", "COMPLETED"])), |
| @pytest.mark.parametrize( | ||
| "event_order", | ||
| list(permutations(["PENDING", "RUNNING", "COMPLETED"])), | ||
| ids=lambda x: "->".join(x), |
CodSpeed Performance ReportMerging #15244 will not alter performanceComparing Summary
|
|
Related to ongoing investigations in #15153 |
cicdw
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
task-run-recorderconsumer takes in task run events, converts them into task runs and task run states, and inserts them into the database. Previously we ensured that these inserts are forced to be done in order of the events occurring through theCausalOrdering.In practice, the only benefit is that if someone were to observe the actual task run state inserts, a
COMPLETEDrow would never exist before aRUNNINGrow. Additionally as long as we are using a queue that is always ordered (currently the only option is an in memory queue), events will never come out of order. Additionally the final state of the task run will always be reported correctly.This PR removes the ordering as there is no real benefit and it is likely adding unnecessary strain to the server.