Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug logging for server side event handling #15245

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

jakekaplan
Copy link
Contributor

@jakekaplan jakekaplan commented Sep 5, 2024

This PR adds some extra debug level logging on:

  • when we publish an event
  • when the events-persister receives an event
  • when the task-run-recorder receives an event

This should give us the full picture of tracking an event from client side emit through persistence.

Related to ongoing investigations in #15153

Copy link

codspeed-hq bot commented Sep 5, 2024

CodSpeed Performance Report

Merging #15245 will not alter performance

Comparing add-event-logging-server-side (be0297d) with main (2b994af)

Summary

✅ 3 untouched benchmarks

Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to the level downgrade too

@cicdw cicdw merged commit a571cf6 into main Sep 6, 2024
30 checks passed
@cicdw cicdw deleted the add-event-logging-server-side branch September 6, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants