Bumps pytest and pytest-asyncio to the latest versions
#15523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were blocked from upgrading `pytest` because we were redefining the `event_loop` fixture, which has been deprecated for some time in `pytest-asyncio`. Here we remove that fixture and set the appropriate configuration per their [docs][1]: * Automatically marks all async tests as being marked with the `asyncio` fixture set to `loop_scope="session" * Make the default fixture loop scope `session` as well (in `setup.cfg`) * In the case where we need to switch to a different policy, like for Windows support, override the `event_loop_policy` fixture One issue emerged here, where any test that called `asyncio.run` or `anyio.run` would leave the test clearing the event loop from the `'MainThread'`, thus poisoning the environment for all subsequent tests. Adding a fixture that restores the session-level `pytest-asyncio` event loop after each test function prevents that issue. Fixes #14559 [1]: https://pytest-asyncio.readthedocs.io/en/latest/how-to-guides/run_session_tests_in_same_loop.html
chrisguidry
requested review from
cicdw,
desertaxle and
zzstoatzz
as code owners
github-actions
bot
added
the
upstream dependency
chrisguidry
commented
Sep 27, 2024
| @@ -1,24 +0,0 @@ | |||
| import pytest | |||
There was a problem hiding this comment.
I discovered this file was a no-op (there is a fixture, but no tests, so I just removed the whole thing)
zzstoatzz
reviewed
Sep 27, 2024
| pytest > 7, < 9 | ||
| pytest-asyncio >= 0.18.2, != 0.22.0, < 0.23.0 # Cannot override event loop in 0.23.0. See https://github.com/pytest-dev/pytest-asyncio/issues/706 for more details. | ||
| pytest >= 8.3 | ||
| pytest-asyncio >= 0.24 |
CodSpeed Performance ReportMerging #15523 will not alter performanceComparing Summary
|
desertaxle
added
the
development
|
Have you considered getting rid of the use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were blocked from upgrading
pytestbecause we were redefining theevent_loopfixture, which has been deprecated for some time inpytest-asyncio. Here we remove that fixture and set the appropriateconfiguration per their docs:
asynciofixtureset to `loop_scope="session"
sessionas well (insetup.cfg)support, override the
event_loop_policyfixtureOne issue emerged here, where any test that called
asyncio.runoranyio.runwould leave the test clearing the event loop from the
'MainThread', thuspoisoning the environment for all subsequent tests. Adding a fixture that
restores the session-level
pytest-asyncioevent loop after each test functionprevents that issue.
Fixes #14559
Checklist
<link to issue>"mint.json.