Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mermaid.js diagram styling in docs #15811

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Update mermaid.js diagram styling in docs #15811

merged 2 commits into from
Oct 28, 2024

Conversation

discdiver
Copy link
Contributor

Updates styling for consistency and visibility in light and dark mode. Simplifies code for the diagrams.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect

Before:
Screenshot 2024-10-25 at 3 35 40 PM

Screenshot 2024-10-25 at 3 36 13 PM

After:
Screenshot 2024-10-25 at 3 54 04 PM

Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just a nit, but can we keep some of the color while remaining compat with light and dark mode? I think a bit of color looks nice

@discdiver
Copy link
Contributor Author

Cool. Agree it would be nice to have some color to liven it up, but think we need to use it consistently and make sure it is visible. I'll merge this PR now as I think it's an improvement over the current state and open something to add some color.

@discdiver discdiver merged commit cf4d65f into main Oct 28, 2024
15 checks passed
@discdiver discdiver deleted the diagram-deploy branch October 28, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants