Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve in container docs #15814

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Serve in container docs #15814

merged 5 commits into from
Oct 28, 2024

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Oct 25, 2024

this is a nice pattern that people have reached themselves despite no documentation on it, this adds a short guide on how to do it

importantly, adds a new section to the nav under Deploy for static infra examples

image

Copy link
Contributor

@discdiver discdiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Thank you! Minor nits for consistency, clarity, and typos.

docs/3.0/deploy/infrastructure-examples/docker.mdx Outdated Show resolved Hide resolved
docs/3.0/deploy/infrastructure-examples/docker.mdx Outdated Show resolved Hide resolved
docs/3.0/deploy/infrastructure-examples/docker.mdx Outdated Show resolved Hide resolved
docs/mint.json Outdated Show resolved Hide resolved
docs/mint.json Outdated Show resolved Hide resolved
docs/3.0/deploy/static-infrastructure-examples/docker.mdx Outdated Show resolved Hide resolved
docs/3.0/deploy/static-infrastructure-examples/docker.mdx Outdated Show resolved Hide resolved
docs/3.0/deploy/static-infrastructure-examples/docker.mdx Outdated Show resolved Hide resolved
docs/3.0/deploy/static-infrastructure-examples/docker.mdx Outdated Show resolved Hide resolved
docs/3.0/deploy/static-infrastructure-examples/docker.mdx Outdated Show resolved Hide resolved
@zzstoatzz
Copy link
Collaborator Author

@discdiver almost all suggestions applied in 96e63f5, commented where I didn't accept

@zzstoatzz zzstoatzz requested a review from discdiver October 28, 2024 19:36
Copy link
Contributor

@discdiver discdiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!!

Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits, but this is awesome!

docs/3.0/deploy/infrastructure-examples/docker.mdx Outdated Show resolved Hide resolved
docs/3.0/deploy/static-infrastructure-examples/docker.mdx Outdated Show resolved Hide resolved
docs/3.0/deploy/static-infrastructure-examples/docker.mdx Outdated Show resolved Hide resolved
Then, run the container in [detached mode](https://docs.docker.com/engine/reference/commandline/run/#detached-d) (in other words, in the background):

```bash
docker run -d --env-file .env my-flow-image
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is dope

@zzstoatzz zzstoatzz force-pushed the serve-in-container-docs branch from c59df47 to 65eaec7 Compare October 28, 2024 20:31
@zzstoatzz zzstoatzz merged commit a2b2ace into main Oct 28, 2024
5 checks passed
@zzstoatzz zzstoatzz deleted the serve-in-container-docs branch October 28, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants