-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serve in container docs #15814
Serve in container docs #15814
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! Thank you! Minor nits for consistency, clarity, and typos.
@discdiver almost all suggestions applied in 96e63f5, commented where I didn't accept |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits, but this is awesome!
Then, run the container in [detached mode](https://docs.docker.com/engine/reference/commandline/run/#detached-d) (in other words, in the background): | ||
|
||
```bash | ||
docker run -d --env-file .env my-flow-image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is dope
Co-authored-by: Alexander Streed <desertaxle@users.noreply.github.com>
c59df47
to
65eaec7
Compare
this is a nice pattern that people have reached themselves despite no documentation on it, this adds a short guide on how to do it
importantly, adds a new section to the nav under
Deploy
for static infra examples