Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in markdown and codspeed workflows #15841

Merged
merged 8 commits into from
Oct 29, 2024
Merged

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Oct 29, 2024

This PR fixes the errors for the markdown and codspeed work flows that are happening on all PRs. Looks like a conflict between pytest-benchmark and other libraries, so this PR removes pytest-benchmark from the two failing work flows. I removed benches/conftest.py to facilitate this change because it isn't as necessary in a CodSpeed world.

@github-actions github-actions bot added the upstream dependency An upstream issue caused by a bug in one of our dependencies label Oct 29, 2024
Copy link

codspeed-hq bot commented Oct 29, 2024

CodSpeed Performance Report

Merging #15841 will not alter performance

Comparing fix-dup-benchmark (4036828) with main (cf4d65f)

Summary

✅ 3 untouched benchmarks

@desertaxle desertaxle added the development Tech debt, refactors, CI, tests, and other related work. label Oct 29, 2024
@desertaxle desertaxle marked this pull request as ready for review October 29, 2024 02:27
Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@desertaxle desertaxle merged commit 6adc56f into main Oct 29, 2024
38 checks passed
@desertaxle desertaxle deleted the fix-dup-benchmark branch October 29, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Tech debt, refactors, CI, tests, and other related work. upstream dependency An upstream issue caused by a bug in one of our dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants