-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 'Configure settings and profiles' documentation to include prefect.toml
support
#15847
Conversation
prefect.toml
supportprefect.toml
support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor suggestions, this is really strong!
|
||
## Settings sources | ||
|
||
You can configure settings via the following sources: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be useful if you explicitly state here that these will be listed in order of precedence, or reverse order of precedence in this case. (And keep the list below too, I just think the redundancy is useful in this case)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense! I added an aside that this list is from highest precedence to lowest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense! I added an aside that this list is from highest precedence to lowest.
|
||
You can configure settings via the following sources: | ||
|
||
- **Environment Variables**: Environment variables are useful for temporarily overriding settings or configuring the runtime environment of a workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- **Environment Variables**: Environment variables are useful for temporarily overriding settings or configuring the runtime environment of a workflow. | |
- **Environment Variables**: Environment variables are useful for temporarily overriding settings or configuring the runtime environment of a workflow or an individual execution of a workflow. |
something to emphasize that env vars are the most dynamically configurable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the wording in ada17ce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm i may have missed something here, but as a fresh reader, would I know when / why to use table headers like [logging]
vs. logging.level
?
I think that's mostly down to personal preference. I can include a link to some TOML documentation for users who want to learn more. Do you think that would help? |
yes! saying its arbitrary / up to yaml in general would be helpful imo |
@zzstoatzz how does this look? |
333cb37
to
a8061c8
Compare
This PR updates the 'Configure settings and profiles' doc to include
prefect.toml
support. I beefed up the intro a little bit to establish what settings enable and how to get started with them. I included a list of supported setting sources and the order they are used to resolve settings values. I also included information about where each setting source is best used.Very open to feedback about the overall structure and recommendation in addition to the specific wording used.
Closes #10697