Adds in the ability for the client to get a remote_id from the server #15849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-phinizy
requested review from
cicdw,
desertaxle and
zzstoatzz
as code owners
CodSpeed Performance ReportMerging #15849 will not alter performanceComparing Summary
|
desertaxle
requested changes
Oct 29, 2024
src/prefect/workers/base.py
Outdated
| if ( | ||
| get_current_settings().experiments.worker_logging_to_api_enabled | ||
| and ( | ||
| "api.prefect.cloud" in get_current_settings().api.url |
There was a problem hiding this comment.
You can check with the current client if it's connected to Cloud like this:
self._client.server_type == ServerType.CLOUD
src/prefect/client/orchestration.py
Outdated
Comment on lines
2607
to
2633
|
|
||
| if get_worker_id: | ||
| return_dict = {"return_id": get_worker_id} | ||
| else: | ||
| return_dict = {} | ||
|
|
||
| resp = await self._client.post( | ||
| f"/work_pools/{work_pool_name}/workers/heartbeat", | ||
| json={ | ||
| "name": worker_name, | ||
| "heartbeat_interval_seconds": heartbeat_interval_seconds, | ||
| }, | ||
| } | ||
| | return_dict, | ||
| ) | ||
|
|
||
| if get_worker_id and resp.status_code == 200: | ||
| return UUID(resp.text) | ||
| else: | ||
| return None |
There was a problem hiding this comment.
I think we might want to include a check for whether the client is connected to Cloud in this method. If someone is using this method directly with an self-hosted server, it'd cause problems.
There was a problem hiding this comment.
By default /heartbeat should only send 204s not 200s but I agree it's probably better to be safe then sorry!
# Conflicts: # src/prefect/settings/models/root.py
…or backward compatibility
sam-phinizy
force-pushed
the
sam-p/get-worker-id-from-server
branch
from
4e8cb41 to
52d747f
Compare
desertaxle
approved these changes
Oct 29, 2024
Co-authored-by: Alexander Streed <desertaxle@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in the optional ability for a worker to get it's ID from the server using the heartbeat mechanism. This should only be enabled if
PREFECT_EXPERIMENTAL_WORKER_LOGGING_API_ENABLEDis set. This PR doesn't do any logging atm, just set the ground work for future PRs.Checklist
<link to issue>"mint.json.