Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds in the worker_id to the LogCreate schema #15851

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

sam-phinizy
Copy link
Contributor

@sam-phinizy sam-phinizy commented Oct 29, 2024

This PR adds in worker_id to the LogCreate schema. Ended up being a lot smaller then i thought it would be.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

@sam-phinizy sam-phinizy force-pushed the sam/update-schemas-for-logs branch 2 times, most recently from 0ed2684 to 0e85183 Compare October 29, 2024 19:54
@sam-phinizy sam-phinizy marked this pull request as ready for review October 29, 2024 19:56
Copy link

codspeed-hq bot commented Oct 29, 2024

CodSpeed Performance Report

Merging #15851 will not alter performance

Comparing sam/update-schemas-for-logs (80cea8c) with main (19f941d)

Summary

✅ 3 untouched benchmarks

@sam-phinizy sam-phinizy marked this pull request as draft October 29, 2024 20:09
@sam-phinizy sam-phinizy marked this pull request as ready for review October 29, 2024 20:09
@sam-phinizy sam-phinizy force-pushed the sam/update-schemas-for-logs branch from 0e85183 to 61633b5 Compare October 29, 2024 20:09
@sam-phinizy sam-phinizy marked this pull request as draft October 29, 2024 20:13
@sam-phinizy sam-phinizy marked this pull request as ready for review October 29, 2024 20:13
@sam-phinizy sam-phinizy force-pushed the sam/update-schemas-for-logs branch from 61633b5 to 7c8a490 Compare October 29, 2024 20:13
@sam-phinizy sam-phinizy marked this pull request as draft October 29, 2024 20:15
@sam-phinizy sam-phinizy marked this pull request as ready for review October 29, 2024 20:16
@sam-phinizy sam-phinizy force-pushed the sam/update-schemas-for-logs branch from 7c8a490 to a3caa76 Compare October 29, 2024 20:16
@sam-phinizy sam-phinizy marked this pull request as draft October 29, 2024 20:21
@sam-phinizy sam-phinizy marked this pull request as ready for review October 29, 2024 20:21
@github-actions github-actions bot added the docs label Oct 29, 2024
@sam-phinizy sam-phinizy marked this pull request as draft October 29, 2024 20:22
@sam-phinizy sam-phinizy force-pushed the sam/update-schemas-for-logs branch from d915973 to 62b84c8 Compare October 29, 2024 20:22
@sam-phinizy sam-phinizy marked this pull request as ready for review October 29, 2024 20:22
@sam-phinizy sam-phinizy marked this pull request as draft October 29, 2024 21:11
@sam-phinizy sam-phinizy marked this pull request as ready for review October 29, 2024 21:11
@sam-phinizy sam-phinizy force-pushed the sam/update-schemas-for-logs branch from 62b84c8 to 8e0e0dd Compare October 29, 2024 21:11
@sam-phinizy sam-phinizy marked this pull request as draft October 29, 2024 21:56
@sam-phinizy sam-phinizy marked this pull request as ready for review October 29, 2024 21:56
Base automatically changed from sam-p/get-worker-id-from-server to main October 29, 2024 22:17
This avoids any compatibility problems with sending worker_id to
an open-source API server.
@sam-phinizy sam-phinizy marked this pull request as draft October 29, 2024 22:19
@sam-phinizy sam-phinizy marked this pull request as ready for review October 29, 2024 22:19
@sam-phinizy sam-phinizy force-pushed the sam/update-schemas-for-logs branch from 27560a5 to f14cbbd Compare October 29, 2024 22:19
@sam-phinizy sam-phinizy marked this pull request as draft October 29, 2024 22:19
@sam-phinizy sam-phinizy marked this pull request as ready for review October 29, 2024 22:19
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sam-phinizy sam-phinizy merged commit 67dd03c into main Oct 30, 2024
16 checks passed
@sam-phinizy sam-phinizy deleted the sam/update-schemas-for-logs branch October 30, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants