-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds in the worker_id to the LogCreate schema #15851
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-phinizy
force-pushed
the
sam/update-schemas-for-logs
branch
2 times, most recently
from
October 29, 2024 19:54
0ed2684
to
0e85183
Compare
sam-phinizy
requested review from
cicdw,
desertaxle and
zzstoatzz
as code owners
October 29, 2024 19:56
CodSpeed Performance ReportMerging #15851 will not alter performanceComparing Summary
|
sam-phinizy
force-pushed
the
sam/update-schemas-for-logs
branch
from
October 29, 2024 20:09
0e85183
to
61633b5
Compare
sam-phinizy
force-pushed
the
sam/update-schemas-for-logs
branch
from
October 29, 2024 20:13
61633b5
to
7c8a490
Compare
sam-phinizy
force-pushed
the
sam/update-schemas-for-logs
branch
from
October 29, 2024 20:16
7c8a490
to
a3caa76
Compare
sam-phinizy
force-pushed
the
sam/update-schemas-for-logs
branch
from
October 29, 2024 20:22
d915973
to
62b84c8
Compare
sam-phinizy
force-pushed
the
sam/update-schemas-for-logs
branch
from
October 29, 2024 21:11
62b84c8
to
8e0e0dd
Compare
This avoids any compatibility problems with sending worker_id to an open-source API server.
sam-phinizy
force-pushed
the
sam/update-schemas-for-logs
branch
from
October 29, 2024 22:19
27560a5
to
f14cbbd
Compare
desertaxle
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in
worker_id
to the LogCreate schema. Ended up being a lot smaller then i thought it would be.Checklist
<link to issue>
"mint.json
.