Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Settings.copy_with_update to ignore sources when restoring default settings #15884

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

desertaxle
Copy link
Member

This PR updates Settings.copy_with_update to ignore settings sources for settings provided to restore_defaults. This will allow users to ignore sources for settings when using the temporary_settings context manager.

Closes #8103

@github-actions github-actions bot added the bug Something isn't working label Oct 31, 2024
Copy link

codspeed-hq bot commented Oct 31, 2024

CodSpeed Performance Report

Merging #15884 will not alter performance

Comparing restore-defaults-for-real (ef64af8) with main (5cfdfd3)

Summary

✅ 3 untouched benchmarks

@desertaxle desertaxle marked this pull request as ready for review October 31, 2024 14:22
@desertaxle desertaxle merged commit 231bfc2 into main Oct 31, 2024
38 checks passed
@desertaxle desertaxle deleted the restore-defaults-for-real branch October 31, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

temporary_settings utility does not restore defaults set by env var
2 participants