Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set COVERAGE_CORE=sysmon to speed up test on 3.12 #15905

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Nov 1, 2024

The 3.12 tests were running slow, so this PR sets COVERAGE_CORE for Python 3.12 tests. I learned about this setting in nedbat/coveragepy#1665. The 3.12 test run significantly faster now and have gone from the slowest to the fastest:

Screenshot 2024-11-01 at 10 17 29 AM

Copy link

codspeed-hq bot commented Nov 1, 2024

CodSpeed Performance Report

Merging #15905 will not alter performance

Comparing unslow-tests (eb24c61) with main (3f31e13)

Summary

✅ 3 untouched benchmarks

@desertaxle desertaxle marked this pull request as ready for review November 1, 2024 15:20
Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@desertaxle desertaxle merged commit b26d891 into main Nov 1, 2024
32 checks passed
@desertaxle desertaxle deleted the unslow-tests branch November 1, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants