Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin replatform of UI to React #15907

Merged
merged 27 commits into from
Nov 4, 2024
Merged

Begin replatform of UI to React #15907

merged 27 commits into from
Nov 4, 2024

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Nov 1, 2024

This PR introduces the foundation for the replatformed Prefect UI. There's a lot here, but these are highlights:

  • New UI bootstrapped with Vite and React
  • New Typescript client generated from Prefect OpenAPI schema and integrates the generated client with @tanstack/react-query
  • Adds several base components using shadcn/ui
  • Adds a couple of example routes using @tanstack/router with query param validation using zod
  • Adds a workflow to verify linting and formatting of the v2 UI

This PR also adds @aaazzam as a codeowner of the ui-v2 directory for reviews.

Related to #15512

@desertaxle desertaxle added the development Tech debt, refactors, CI, tests, and other related work. label Nov 1, 2024
@desertaxle desertaxle marked this pull request as ready for review November 4, 2024 19:18
@aaazzam
Copy link
Collaborator

aaazzam commented Nov 4, 2024

lgtm, though I'd like to not carry forward the state iconography. My preference is to roll as many lucide icons as we can stomache.

@desertaxle
Copy link
Member Author

lgtm, though I'd like to not carry forward the state iconography. My preference is to roll as many lucide icons as we can stomache.

Cool, I can take those out.

@desertaxle desertaxle merged commit d332172 into main Nov 4, 2024
8 checks passed
@desertaxle desertaxle deleted the react-ui branch November 4, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants