Setup OpenTelemetry exporters when initializing prefect #15946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bunchesofdonald
added
the
development
bunchesofdonald
requested review from
aaazzam,
chrisguidry,
cicdw,
desertaxle,
zzstoatzz and
discdiver
as code owners
github-actions
bot
added
docs
upstream dependency
CodSpeed Performance ReportMerging #15946 will not alter performanceComparing Summary
|
chrisguidry
reviewed
Nov 7, 2024
Yeah, I'm working on something like that, having a |
Co-authored-by: Chris Guidry <chris.g@prefect.io>
bunchesofdonald
force-pushed
the
CLOUD-563-config
branch
from
9c10a12 to
2674b32
Compare
desertaxle
approved these changes
Nov 8, 2024
| if server_type != ServerType.CLOUD: | ||
| return None, None, None | ||
|
|
||
| assert settings.api.key |
There was a problem hiding this comment.
If you need an API key for this to work, can we raise a friendly error when the API key is missing?
There was a problem hiding this comment.
Yeah, I have a ticket to come through and make this a more friendly thing in general: https://linear.app/prefect/issue/CLOUD-675/make-telemetry-failures-more-friendly
Co-authored-by: Alexander Streed <desertaxle@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds OpenTelemetry support to Prefect Cloud by setting up exporters for traces, metrics, and logs during initialization when enabled.
Key changes: