Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the direction of our integration string replacement #15959

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

abrookins
Copy link
Collaborator

Small fix: when we send worker metadata and normalize the way our collections and distributions() report package names, expect the integration to use underscores and the distribution to use dashes.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Copy link

codspeed-hq bot commented Nov 8, 2024

CodSpeed Performance Report

Merging #15959 will not alter performance

Comparing fix-worker-metadata-string-replace (463186a) with main (d6a4842)

Summary

✅ 3 untouched benchmarks

@cicdw cicdw merged commit 41d3906 into main Nov 8, 2024
36 checks passed
@cicdw cicdw deleted the fix-worker-metadata-string-replace branch November 8, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants