Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug log for global concurrency limit wait #16077

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

EmilRex
Copy link
Contributor

@EmilRex EmilRex commented Nov 21, 2024

Adds a single debug log message with the Retry-After header that's returned when a global concurrency slot is unavailable. This will help users understand how long a flow run might be in a waiting state since that amount of time is variable and determined by the server.

Copy link

codspeed-hq bot commented Nov 21, 2024

CodSpeed Performance Report

Merging #16077 will not alter performance

Comparing log-concurrency-slot-retry-after (c1fabd5) with main (b979ca5)

Summary

✅ 3 untouched benchmarks

Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

src/prefect/concurrency/services.py Outdated Show resolved Hide resolved
EmilRex and others added 2 commits November 21, 2024 15:07
@EmilRex EmilRex merged commit d296aa2 into main Nov 21, 2024
36 checks passed
@EmilRex EmilRex deleted the log-concurrency-slot-retry-after branch November 21, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants