-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI v2] Refactor parts of variables components #16084
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desertaxle
force-pushed
the
ui-v2-variables-edit
branch
from
November 21, 2024 20:00
a7b819b
to
f6f5d13
Compare
desertaxle
force-pushed
the
ui-v2-variables-refactor
branch
from
November 21, 2024 20:16
ec9f7fb
to
ddd3523
Compare
desertaxle
added
the
development
Tech debt, refactors, CI, tests, and other related work.
label
Nov 21, 2024
desertaxle
requested review from
aaazzam,
cicdw and
zzstoatzz
as code owners
November 21, 2024 20:28
desertaxle
changed the title
UI v2 variables refactor
[UI v2] Refactor parts of variables components
Nov 21, 2024
if the tag name has one character, it'll error out with an "undefined" error |
filtering by variable name doesn't require pressing return, filtering by tag does. (I get why, but it's a little annoying -- not blocking) |
aaazzam
reviewed
Nov 24, 2024
aaazzam
approved these changes
Nov 24, 2024
Removes some prop drilling
desertaxle
force-pushed
the
ui-v2-variables-refactor
branch
from
November 25, 2024 15:09
689a6b3
to
327e3c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the core functionality is in place, I went through what's been created so for to refactor and polish. The code of this refactor is to reduce prop drilling, increase readbility and increase reusability of existing functionality.
Here are some of the highlights in no particular order:
useVariables
hook.query_key
creation has been consolidated to prevent typo-based errors.Related to #15512