Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm docs referencing incidents #16139

Merged
merged 1 commit into from
Nov 27, 2024
Merged

rm docs referencing incidents #16139

merged 1 commit into from
Nov 27, 2024

Conversation

aaazzam
Copy link
Collaborator

@aaazzam aaazzam commented Nov 27, 2024

👋

Copy link
Contributor

@discdiver discdiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaazzam, do you think we should add a redirect for the removed page to the mint.json file? As it stands now, users will redirect to https://docs.prefect.io/v3/get-started/index - which is maybe fine, but want to make sure that's intended behavior.

@aaazzam
Copy link
Collaborator Author

aaazzam commented Nov 27, 2024

@aaazzam, do you think we should add a redirect for the removed page to the mint.json file? As it stands now, users will redirect to https://docs.prefect.io/v3/get-started/index - which is maybe fine, but want to make sure that's intended behavior.

good call, I think a naked redirect to get-started is fine

@discdiver discdiver self-requested a review November 27, 2024 20:32
Copy link
Contributor

@discdiver discdiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aaazzam aaazzam merged commit 8f71520 into main Nov 27, 2024
11 checks passed
@aaazzam aaazzam deleted the rm-docs-incidents branch November 27, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants