Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround respx incompatibility with httpx==0.28.0 #16168

Merged
merged 18 commits into from
Dec 2, 2024
Merged

Workaround respx incompatibility with httpx==0.28.0 #16168

merged 18 commits into from
Dec 2, 2024

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Dec 2, 2024 •
edited
Loading

This PR updates respx.mock calls to include using="httpx" to mock at the httpx level instead of the httpcore level. This mitigates respx not being compatible with httpx==0.28.0.

@github-actions github-actions bot added the upstream dependency An upstream issue caused by a bug in one of our dependencies label Dec 2, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 2, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #16168 will not alter performance

Comparing respx-workaround (9456bc0) with fix-ssl-verify-ctx (0a6c723)

Summary

✅ 3 untouched benchmarks

@zzstoatzz zzstoatzz mentioned this pull request Dec 2, 2024
Merged
@desertaxle desertaxle marked this pull request as ready for review December 2, 2024 22:01
zzstoatzz
zzstoatzz approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@desertaxle desertaxle merged commit ea03de4 into fix-ssl-verify-ctx Dec 2, 2024
35 checks passed
@desertaxle desertaxle deleted the respx-workaround branch December 2, 2024 22:02
zzstoatzz pushed a commit that referenced this pull request Dec 2, 2024
@desertaxle @zzstoatzz
Workaround respx incompatibility with httpx==0.28.0 (#16168)
64618b6
@zzstoatzz zzstoatzz mentioned this pull request Dec 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzstoatzz zzstoatzz zzstoatzz approved these changes

@cicdw cicdw Awaiting requested review from cicdw

Assignees
No one assigned
Labels
upstream dependency An upstream issue caused by a bug in one of our dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@desertaxle @zzstoatzz