fix __getattr__
conflict in prefect.docker.__init__
#16172
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #16171
Fix
unittest.assertWarns()
compatibility with module__getattr__
handling inprefect.docker.__init__
issue arises bc unittest's
assertWarns
usesgetattr()
with a default value to safely check for__warningregistry__
on moduleshttps://github.com/python/cpython/blob/e546876d83e1cc3f761e1eeca57f8a4533d06d00/Lib/unittest/case.py#L290-L294
Our
__getattr__
implementation was raisingImportError
, preventing Python from handling the default value case, so this PR changes it to raiseAttributeError
to follow attribute lookup protocol (like the other dynamic imports we have)