Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve typing of variables.py #16216

Merged
merged 1 commit into from
Dec 4, 2024
Merged

improve typing of variables.py #16216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/prefect/variables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,17 +73,18 @@ def my_flow():
raise ValueError(
f"Variable {name!r} already exists. Use `overwrite=True` to update it."
)
await client.update_variable(variable=VariableUpdate(**var_dict))
await client.update_variable(
variable=VariableUpdate.model_validate(var_dict)
)
variable = await client.read_variable_by_name(name)
var_dict = {
"name": variable.name,
"value": variable.value,
"tags": variable.tags or [],
}
for key in var_dict.keys():
var_dict.update({key: getattr(variable, key)})
else:
await client.create_variable(variable=VariableCreate(**var_dict))
await client.create_variable(
variable=VariableCreate.model_validate(var_dict)
)

return cls(**var_dict)
return cls.model_validate(var_dict)

@classmethod
@sync_compatible
Expand Down
Loading