Improve typing completeness of internal base models #16217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desertaxle
added
the
development
CodSpeed Performance ReportMerging #16217 will not alter performanceComparing Summary
|
desertaxle
changed the title
mjpieters
reviewed
Dec 4, 2024
| @@ -58,7 +58,7 @@ def __eq__(self, other: Any) -> bool: | |||
| else: | |||
| return copy_dict == other | |||
|
|
|||
| def __rich_repr__(self): | |||
| def __rich_repr__(self) -> Generator[tuple[str, Any, Any], None, None]: | |||
There was a problem hiding this comment.
Pro tip: use rich.repr.RichReprResult for annotating these methods.
Otherwise, when only using yield and not other generator features like sending and returning, it's often sufficient to use Iterator[..] to annotate methods like these. That you used a generator function to implement the iterator is then a mere implementation detail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully defines the base models in
prefect._internal.schemas.baseto improve type completeness by 2.1%.