[typing] Use correct type narrowing construct #16269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjpieters
requested review from
cicdw,
desertaxle and
zzstoatzz
as code owners
CodSpeed Performance ReportMerging #16269 will not alter performanceComparing Summary
|
|
Looks like all of the npm infrastructure briefly ate itself and several jobs in the pipeline here failed because of this. I'll have to see if I can't force-push something to trigger re-running. |
`TypeIs` should only be used if the negative result excludes the narrowed type.
mjpieters
force-pushed
the
correct_type_guard
branch
from
ea1a943 to
f68949a
Compare
desertaxle
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeIsshould only be used if the negative result excludes the narrowed type.Also see #16265 (comment)