Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.9 compat for debug.mdx tutorial #16296

Merged
merged 1 commit into from
Dec 9, 2024
Merged

3.9 compat for debug.mdx tutorial #16296

merged 1 commit into from
Dec 9, 2024

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Dec 9, 2024 •
edited
Loading

#16225 breaks the markdown tests everywhere because we run them with 3.9 and T | None is introduced in 3.10

@zzstoatzz zzstoatzz added the development Tech debt, refactors, CI, tests, and other related work. label Dec 9, 2024
@github-actions github-actions bot added the docs label Dec 9, 2024
@zzstoatzz zzstoatzz self-assigned this Dec 9, 2024
discdiver
discdiver approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@discdiver discdiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY

@zzstoatzz zzstoatzz merged commit 5d1c88e into main Dec 9, 2024
13 checks passed
@zzstoatzz zzstoatzz deleted the fix-tutorial-typing branch December 9, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@discdiver discdiver discdiver approved these changes

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

@daniel-prefect daniel-prefect Awaiting requested review from daniel-prefect

Assignees

@zzstoatzz zzstoatzz

Labels
development Tech debt, refactors, CI, tests, and other related work. docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zzstoatzz @discdiver