-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typing] prefect.utilities #16298
[typing] prefect.utilities #16298
Conversation
2defb4a
to
46cc5ae
Compare
CodSpeed Performance ReportMerging #16298 will not alter performanceComparing Summary
|
6734b73
to
731d01e
Compare
@@ -123,68 +123,32 @@ def create_task(coroutine: Coroutine) -> asyncio.Task: | |||
return task | |||
|
|||
|
|||
def _run_sync_in_new_thread(coroutine: Coroutine[Any, Any, T]) -> T: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just noting that this is unused, so removing it makes sense to me 👍
@chrisguidry The following lines are (rightfully) marked by pyright as having an issue because @handler("workspace_variable")
def workspace_variable_handler(obj: dict[str, Any], ctx: HydrationContext) -> Any:
if "variable_name" in obj:
if isinstance(obj["variable_name"], dict):
dehydrated_variable = _hydrate(obj["variable_name"], ctx)
else:
dehydrated_variable = obj["variable_name"]
# If the result is a Placeholder, we should return it as is
if isinstance(dehydrated_variable, Placeholder):
return dehydrated_variable
if not ctx.render_workspace_variables:
return WorkspaceVariable(variable_name=obj["variable_name"]) Is it safe to assert that |
Great question @mjpieters: I would use the |
a3a5ec3
to
9b27ace
Compare
fc106ad
to
94f853a
Compare
This PR brings the type completeness up by 2.74%. |
94f853a
to
dd9f58e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! ill hold for @desertaxle to give a review as well
dd9f58e
to
bc236a1
Compare
No description provided.