Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate use of DateTime to prefect.types #16356

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Dec 12, 2024

see pydantic/pydantic-extra-types#239

to minimize the pain of any future DateTime migration, route all imports of pydantic_extra_types.pendulum_dt.DateTime through prefect.types.DateTime

image


this somehow got me type completeness 🤷

image

@github-actions github-actions bot added the docs label Dec 12, 2024
Copy link

codspeed-hq bot commented Dec 12, 2024

CodSpeed Performance Report

Merging #16356 will not alter performance

Comparing consolidate-datetime (18d777d) with main (089bcec)

Summary

✅ 3 untouched benchmarks

@zzstoatzz zzstoatzz added the development Tech debt, refactors, CI, tests, and other related work. label Dec 12, 2024
@zzstoatzz zzstoatzz self-assigned this Dec 12, 2024
@zzstoatzz zzstoatzz marked this pull request as ready for review December 12, 2024 04:20
Copy link
Collaborator

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

@zzstoatzz zzstoatzz merged commit c2c0fd6 into main Dec 12, 2024
56 checks passed
@zzstoatzz zzstoatzz deleted the consolidate-datetime branch December 12, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants