Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typing] Remove overload from inject_client #16463

Merged

Conversation

mjpieters
Copy link
Contributor

@mjpieters mjpieters commented Dec 19, 2024

The decorator can't accept a regular callable (it uses await when calling the wrapped function), and has so far never been used on anything but coroutines.

References #16292 and #16341.

The decorator can't accept a regular callable (it uses `await` when
calling the wrapped function), and has so far never been used on
anything but coroutines.
@github-actions github-actions bot added docs ui-replatform Related to the React UI rewrite labels Dec 19, 2024
@mjpieters mjpieters marked this pull request as ready for review December 19, 2024 23:01
Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #16463 will not alter performance

Comparing mjpieters:mj/typing_correct_inject_client (b341f27) with main (26041af)

Summary

✅ 3 untouched benchmarks

@github-actions github-actions bot added the development Tech debt, refactors, CI, tests, and other related work. label Dec 19, 2024
@desertaxle desertaxle removed docs ui-replatform Related to the React UI rewrite labels Dec 19, 2024
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@desertaxle desertaxle merged commit 2768adb into PrefectHQ:main Dec 19, 2024
47 checks passed
@mjpieters mjpieters deleted the mj/typing_correct_inject_client branch December 19, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants