Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass auth headers to /csrf #16464

Merged
merged 6 commits into from
Dec 20, 2024
Merged

pass auth headers to /csrf #16464

merged 6 commits into from
Dec 20, 2024

Conversation

aaazzam
Copy link
Collaborator

@aaazzam aaazzam commented Dec 20, 2024

in #16411, auth headers were passed to the central client-side API service which brokers all requests, except for the one to refresh the csrf token. With CSRF protection turned on, this means that PREFECT_SERVER_API_AUTH_STR showed a persistent login screen.

This PR does three things:

@github-actions github-actions bot added bug Something isn't working docs ui Related to the Prefect web interface labels Dec 20, 2024
Copy link

codspeed-hq bot commented Dec 20, 2024

CodSpeed Performance Report

Merging #16464 will not alter performance

Comparing auth-ui-csrf-handling (94382c5) with main (a0248c7)

Summary

✅ 3 untouched benchmarks

@aaazzam aaazzam enabled auto-merge (squash) December 20, 2024 04:42
Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like it works 👍🏻

@aaazzam aaazzam merged commit a7033fa into main Dec 20, 2024
38 checks passed
@aaazzam aaazzam deleted the auth-ui-csrf-handling branch December 20, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs ui Related to the Prefect web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSRF in combination with basic auth breaks UI
3 participants