-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix overloads for wait_for
and return_state
in Task.__call__
#16547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #16547 will not alter performanceComparing Summary
|
zzstoatzz
force-pushed
the
dunder-call-wait-for-typing
branch
from
December 30, 2024 04:16
8324e01
to
0a3fa15
Compare
zzstoatzz
added
the
development
Tech debt, refactors, CI, tests, and other related work.
label
Dec 30, 2024
zzstoatzz
changed the title
add overload for
fix overloads for Dec 30, 2024
wait_for_
in Task.__call__
wait_for
in Task.__call__
zzstoatzz
changed the title
fix overloads for
fix overloads for Dec 30, 2024
wait_for
in Task.__call__
wait_for
and return_state
in Task.__call__
desertaxle
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about using forward refs in the task engine for stuff from prefect.tasks
, but otherwise this is great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds an overload to make the type checker handle
wait_for
when calling tasks directly, pyright complains on mainalso makes various
Dict
->dict
changes and adds a private alias to make the overloads as shown by IDE easier to grokmain
this branch
example