Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Add information about task inputs #8295

Merged
merged 21 commits into from
Mar 1, 2023
Merged

BugFix: Add information about task inputs #8295

merged 21 commits into from
Mar 1, 2023

Conversation

zhen0
Copy link
Member

@zhen0 zhen0 commented Jan 28, 2023

image

Screenshot 2023-02-01 at 12 00 33 PM

The current task run page has a misleading tab called "task inputs". This adds a modal to explain its purpose.
Closes #7547 and #6627

@madkinsz - for comment here. I'd welcome your input on the explanation. I'd prefer not to remove the tab completely in case it was useful to some users.

Example

The UI task run page has a Task Input tab that causes confusion

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. fix, feature, enhancement

@netlify
Copy link

netlify bot commented Jan 28, 2023

Deploy Preview for prefect-docs ready!

Name Link
🔨 Latest commit b83a39b
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs/deploys/63ffb9571ecf3f0008d5821b
😎 Deploy Preview https://deploy-preview-8295--prefect-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zanieb
Copy link
Contributor

zanieb commented Jan 30, 2023

@zhen0 we'll also track relationships that aren't from futures, i.e. if you have a task that returns some object then a later task that uses it (and it's a uniquely identifiable object) we'll show the relationship here.

@zhen0
Copy link
Member Author

zhen0 commented Feb 7, 2023

@zhen0 zhen0 changed the title BugFix: Change task inputs to task futures BugFix: Add information about task inputs Feb 7, 2023
@zhen0 zhen0 marked this pull request as ready for review February 7, 2023 18:40
@zhen0 zhen0 requested a review from pleek91 as a code owner February 7, 2023 18:40
@zhen0 zhen0 requested a review from zanieb February 7, 2023 18:40
@zhen0 zhen0 marked this pull request as draft February 9, 2023 13:40
@zhen0
Copy link
Member Author

zhen0 commented Feb 9, 2023

Converting to draft until PrefectHQ/prefect-ui-library#1136 is released

@zhen0 zhen0 marked this pull request as ready for review February 28, 2023 15:34
@zhen0 zhen0 requested a review from pleek91 March 1, 2023 20:53
@zhen0 zhen0 merged commit 28b1fc9 into main Mar 1, 2023
@zhen0 zhen0 deleted the remove-inputs branch March 1, 2023 21:49
ddelange added a commit to ddelange/prefect that referenced this pull request Mar 2, 2023
…eful-agent

* 'main' of https://github.com/prefecthq/prefect:
  BugFix: Add information about task inputs (PrefectHQ#8295)
  Handle SIGTERM received by server gracefully (PrefectHQ#7948)
@zanieb zanieb mentioned this pull request Mar 20, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to task input tab on the task run page
4 participants