Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks Support: Create prefect_block resource - Update() #182

Closed
parkedwards opened this issue May 31, 2024 · 2 comments · Fixed by #198
Closed

Blocks Support: Create prefect_block resource - Update() #182

parkedwards opened this issue May 31, 2024 · 2 comments · Fixed by #198
Assignees
Labels
enhancement New feature or request

Comments

@parkedwards
Copy link
Contributor

parkedwards commented May 31, 2024

https://www.notion.so/prefect/Design-Block-support-in-the-Terraform-Provider-ae2ea25a18864de9b51b8aa06af9486b?pvs=4

resource "prefect_block" "datadog_api_key" {
	name = "datadog-api-key"
	type = "secret"
	data = jsonencode({
		value = var.datadog_api_key
	})
}

Located in internal/provider/resources/block.go

We'll need to add a Update() method on the pointer receiver for the BlockResource struct.

Afterwards we should be able to: update the data value in an existing block, eg. like in a key rotation scenario.

@mitchnielsen mitchnielsen self-assigned this Jun 3, 2024
mitchnielsen added a commit that referenced this issue Jun 4, 2024
Implements BlockSource.Read method.

Closes #182
mitchnielsen added a commit that referenced this issue Jun 4, 2024
Implements BlockSource.Read method.

Closes #182
@parkedwards parkedwards changed the title Blocks Support: Create prefect_block resource - Update(), Delete() Blocks Support: Create prefect_block resource - Update() Jun 4, 2024
@mitchnielsen mitchnielsen reopened this Jun 4, 2024
@mitchnielsen
Copy link
Contributor

We moved things around, so the branch name from 0b1fb3d should no longer closet his one. Reopened.

@mitchnielsen
Copy link
Contributor

Will wait for #174 before tackling this one.

@mitchnielsen mitchnielsen added the enhancement New feature or request label Jun 6, 2024
mitchnielsen added a commit that referenced this issue Jun 6, 2024
Implements Update method for BlockResource type.

Closes #182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants