Improve Diagnostics consistency #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchnielsen
added
the
maintenance
mitchnielsen
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
Uses a constant for the report message so we can call it where needed.
Adds and implements a new helper to call when there's an unexpected type during configuration of a data source or resource.
mitchnielsen
force-pushed
the
diagnostics-consistency
branch
from
f11c594 to
55bb3e2
Compare
mitchnielsen
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
Ensures that ResourceClientErrorDiagnostic is called when appropriate.
mitchnielsen
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
Ensures CreateClientErrorDiagnostic is used where appropriate.
mitchnielsen
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
Implements a new helper to use when serializing to JSON string fails.
Implements a helper for use when parsing UUIDs fails.
mitchnielsen
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
|
This is a bigger one, but if you look at each commit, the changes are pretty repetitive/predictable. Also, a majority of the changes are lines removed rather than changed/added. |
parkedwards
reviewed
Jun 18, 2024
parkedwards
approved these changes
Jun 18, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #212
returnon diagnostic errorsTo do