Remove heading capitalization #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many languages don't use title case, so forcing it by CSS makes the headings look weird. Let every language decide if it'll use capitalization when doing the translation.
|
I should add that my language does not have title case, period. It only has lower, upper and sentence case. I blame the title case not looking completely off in some cases on the anglicization of all world's languages. |
|
@the-ge Thank you for your contribution. Could you create an issue on PrestaShop repository : https://github.com/PrestaShop/PrestaShop/issues/new/choose ? |
|
Would PrestaShop/PrestaShop#25997 do? |
|
@the-ge I added the ticket to your PR description, it looks relevant to me let's wait for the issue to be approved :) |
NeOMakinG
approved these changes
Sep 27, 2021
PierreRambaud
approved these changes
Sep 27, 2021
|
Hello @the-ge , Thanks for the PR, LGTM ! |
florine2623
added
QA ✔️
|
Thank you @florine2623 and @the-ge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many languages don't use title case, so forcing it by CSS makes the headings look weird. In my language, title case prepositions are a definite no-no.
Let every language decide if it'll use capitalization when doing the translation. Or make it upper case - I think that would be gramarly ok, although less flexible.