Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad display when multishop enable #277

Merged
merged 2 commits into from Oct 22, 2021
Merged

Fix bad display when multishop enable #277

merged 2 commits into from Oct 22, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 29, 2021

Questions Answers
Description? Fix bad display when multishop enable
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#26025
How to test? See issue

@NeOMakinG NeOMakinG added this to the 5.1.0 milestone Sep 30, 2021
@Progi1984 Progi1984 added the waiting for QA Status: Waiting for QA feedback label Oct 18, 2021
@florine2623 florine2623 self-assigned this Oct 20, 2021
@florine2623
Copy link
Contributor

Hello @okom3pom ,

Thanks for the PR ! Configuration block is well displayed !

I just need to make sure this is the wanted behavior :
Without PR :
Screenshot 2021-10-20 at 11 53 28

With PR :
Screenshot 2021-10-20 at 11 53 50

Let me know!
Thanks!

@florine2623 florine2623 added the waiting for author Status: Waiting for Author Feedback label Oct 20, 2021
@NeOMakinG
Copy link

@florine2623 It looks like it's not the design we want but the markup is sooo wrong...

@okom3pom at least, can you add a class to the blockcontent and modify the CSS rule you removed to aim the new class you added? 🙏

@ghost
Copy link
Author

ghost commented Oct 20, 2021

16347328978952903546082640667726

I am on

@ghost ghost mentioned this pull request Oct 21, 2021
@florine2623
Copy link
Contributor

Hello @okom3pom ,

Thanks for the update, looking good !

@florine2623 florine2623 added QA ✔️ Status: QA-Approved and removed waiting for author Status: Waiting for Author Feedback waiting for QA Status: Waiting for QA feedback labels Oct 22, 2021
@Progi1984 Progi1984 merged commit 29fcfa6 into PrestaShop:dev Oct 22, 2021
@Progi1984
Copy link
Member

Thanks @okom3pom & @florine2623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA ✔️ Status: QA-Approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad display when multishop enable Blockreassurance
4 participants