-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bad display when multishop enable #277
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Sep 29, 2021
•
edited by Progi1984
Loading
edited by Progi1984
Questions | Answers |
---|---|
Description? | Fix bad display when multishop enable |
Type? | bug fix |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | Fixes PrestaShop/PrestaShop#26025 |
How to test? | See issue |
NeOMakinG
approved these changes
Sep 30, 2021
Progi1984
approved these changes
Oct 18, 2021
@florine2623 It looks like it's not the design we want but the markup is sooo wrong... @okom3pom at least, can you add a class to the blockcontent and modify the CSS rule you removed to aim the new class you added? 🙏 |
ghost
mentioned this pull request
Oct 21, 2021
NeOMakinG
approved these changes
Oct 21, 2021
Hello @okom3pom , Thanks for the update, looking good ! |
florine2623
added
QA ✔️
Status: QA-Approved
and removed
waiting for author
Status: Waiting for Author Feedback
waiting for QA
Status: Waiting for QA feedback
labels
Oct 22, 2021
Thanks @okom3pom & @florine2623 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.