Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to remove a block #37

Merged
merged 4 commits into from
Dec 4, 2019
Merged

Conversation

Progi1984
Copy link
Member

Questions Answers
Description? Added the ability to remove a block
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#15935
How to test? * Add a new block item
* Check the front it is not here
* Enable it
* Check the front it is here
* Edit it
* Check the front it is here
* Remove it
* Check the front it is not here

@Progi1984 Progi1984 requested a review from a team November 18, 2019 13:59
@matks
Copy link
Contributor

matks commented Nov 18, 2019

You removed 2700 lines 😄 is that intentional for this PR ?

@Progi1984
Copy link
Member Author

You removed 2700 lines smile is that intentional for this PR ?

Yes, Webpack compress to multiline into oneline now ;)

_dev/back/index.js Outdated Show resolved Hide resolved
_dev/back/index.js Outdated Show resolved Hide resolved
@PierreRambaud PierreRambaud added the waiting for QA Status: Waiting for QA feedback label Nov 18, 2019
@sarahdib sarahdib added QA ✔️ Status: QA-Approved and removed waiting for QA Status: Waiting for QA feedback labels Dec 3, 2019
@matks
Copy link
Contributor

matks commented Dec 4, 2019

Thank you @Progi1984

@matks matks merged commit d89a627 into PrestaShop:dev Dec 4, 2019
@Progi1984 Progi1984 deleted the issue15935 branch December 4, 2019 10:19
@matks matks added the Improvement Type: Improvement label Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Type: Improvement QA ✔️ Status: QA-Approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants