Fix get mime type

[Progi1984]

Questions	Answers
Description?	Fix get mime type
Type?	bug fix
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes PrestaShop/PrestaShop#20254
How to test?	See below

How to test ?

See "failure scenario" described at the bottom of this PR: #55 (comment)

• failure scenario should only happen with blockreassurance v5.0.0 on PS 1.7.6 ; on PS 1.7.7 it should be fine
• please verify that, when using this PR, the issue is solved on PS 1.7.6 and on PS 1.7.7 the issue is still not there

[matks]

@Progi1984 We need to revert my change where I modify the compatibility scope else QA will not be able to test on 1.7.6.x.

Also we need to provide QA a specific scenario to observe the issue so they can compare before/after the PR

[Progi1984]

@matks Revert the compability scope.

[matks]

PR approved 👍 ready to go to QA but we need to find a failure scenario for QA, so they can assert that "with v5.0.0 it fails and with (future) v5.0.1 it works"

[reanim8ed]

@Progi1984 I get this error:

The problem occurs because PS_BASE_URI = '/'

[matks]

I have collected a reproductible scenario for QA to be able to observe and explore the bug :

1. install blockreassurance v5.0.0 on PS 1.7.6.7

2. modify file themes/classic/templates/catalog/product.tpl and replace line 148

{hook h='displayReassurance'}

by

{widget name="blockreassurance"}

This will now use blockreassurance as a Widget and not like a Hook.

3. open BO configuration page for the module and edit one of the 3 reassurance items: you need to upload a custom icon

4. now open the FO product page

• on some environments the page will crash
• on other environments the module will silently fail: the reassurance items will not be displayed (the block will appear empty) however you will see in Apache PHP logs the error PHP Fatal error: Uncaught Error: Call to undefined method ImageManager::getMimeType() in /modules/blockreassurance/classes/ReassuranceActivity.php:190

This should be fixed by this PR

[matks]

@Progi1984 I get this error:

The problem occurs because PS_BASE_URI = '/'

I am sorry I dont understand this. It does not seem related to this PR, is it ?

[reanim8ed]

@Progi1984 I get this error:

The problem occurs because PS_BASE_URI = '/'

I am sorry I dont understand this. It does not seem related to this PR, is it ?

I found that the issue was introduced here: 37d0fb1#diff-e6316994746d2ce5be44c53e7d2527c3R190

ImageManager::getMimeType doesnt receive correct file location because str_replace returns wrong result then PS_BASE_URI = '/'.

Probably it should be registered as new issue.

[sarahdib]

@matks
I try to reproduce the initial error but it's working without the PR for me :

[matks]

@matks
I try to reproduce the initial error but it's working without the PR for me :

Is this a 1.7.6 shop ?

[Progi1984]

@matks

failure scenario should only happen with blockreassurance v5.0.0 on PS 1.7.6 ; on PS 1.7.7 it should be fine

Yes

[Progi1984]

Thanks @sarahdib

[andromaque]

Hi @Progi1984 and @PierreRambaud,

This bug has been fixed a few months ago, targeted for version 5.1.0... but the current version is still 5.0.0.
When could we expect the release of the new version of the module?

Thank you

[KamikStudio]

@matks I have a problem with blockreassurance as well. I changed to {widget h = 'displayReassurance'}, saved the file, refreshed the cache and received a message (the one before)

ContextErrorException
.......iposomal.png): failed to open stream: No such file or directory

[KamikStudio]

@Progi1984 and when the solution?

[Frostbourn]

We need a fix.

[matks]

Hello everyone, there is a huge overload of work on teams right now and many other important items requiring focus which is why v5.1.0 is not out yet. However you can use the code from dev branch to fix your module in production while waiting for the official release although it is not validated by QA (I trust you can do the necessary testing to verify the behavior 😉 )

• this PR Fix get mime type #55 fixes Customer Reassurance module v5 crashes when used as widget with PS 1.7.6 PrestaShop#20254
• the PR Expose full blocks as widget elements #60 is likely to fix Blockreassurance - URL not available in front office PrestaShop#21752
• the PR Fix issues with blockreassurance #209 is likely to fix Bad display on blockreassurance configuration page PrestaShop#22892

@matks I have a problem with blockreassurance as well. I changed to {widget h = 'displayReassurance'}, saved the file, refreshed the cache and received a message (the one before)

ContextErrorException
.......iposomal.png): failed to open stream: No such file or directory

Hello @KamikStudio look at my PR #60 it might help you. I unfortunately don't have the time to continue working on it and there was a feedback from QA I could not process. You can pick up my work and even submit it as your own if you want to push the topic forward.