Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Img modal fix #65

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Img modal fix #65

merged 1 commit into from
Oct 19, 2022

Conversation

JBLach
Copy link
Contributor

@JBLach JBLach commented Oct 19, 2022

Questions Answers
Description? Img modal fix
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #30056
How to test? See screenshots below.
Possible impacts? Please indicate what parts of the software we need to check to make sure everything is alright.

image
image
image

@kpodemski kpodemski added the Waiting for QA Status: Waiting for QA feedback label Oct 19, 2022
@kpodemski kpodemski added this to the 2.0.5 milestone Oct 19, 2022
@HanaRebaiQA HanaRebaiQA self-assigned this Oct 19, 2022
@AureRita AureRita assigned AureRita and HanaRebaiQA and unassigned HanaRebaiQA and AureRita Oct 19, 2022
jolelievre
jolelievre approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JBLach

NeOMakinG
NeOMakinG approved these changes Oct 19, 2022
View reviewed changes
Copy link

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be acceptable 🍬

HanaRebaiQA
HanaRebaiQA approved these changes Oct 19, 2022
View reviewed changes
Copy link

@HanaRebaiQA HanaRebaiQA left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @JBLach

I have checked this PR. the issue is well fixed.

Here is my checked list :

  • Check the display of images in FO : OK
  • Check the merged PRs in classic theme : OK
  • Check with different product types : OK
  • Check with multistore (New shop, new group of shop): OK
  • Check with different languages : OK
  • Check with responsive and tablet : OK
  • Check with different browsers : OK

image
image
image
image
image

So, it's Qa ✔️

Thank You!

@HanaRebaiQA HanaRebaiQA added QA ✔️ Status: QA-Approved and removed Waiting for QA Status: Waiting for QA feedback labels Oct 19, 2022
@jolelievre jolelievre merged commit a29e863 into PrestaShop:develop Oct 19, 2022
@jolelievre jolelievre changed the title img modal fix Img modal fix Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HanaRebaiQA HanaRebaiQA HanaRebaiQA approved these changes

@NeOMakinG NeOMakinG NeOMakinG approved these changes

@jolelievre jolelievre jolelievre approved these changes

@kpodemski kpodemski kpodemski approved these changes

Assignees

@HanaRebaiQA HanaRebaiQA

Labels
QA ✔️ Status: QA-Approved
Projects
None yet
Milestone
2.0.5
Development

Successfully merging this pull request may close these issues.

FO - The images are not well displayed in the product details page
6 participants
@JBLach @kpodemski @jolelievre @NeOMakinG @HanaRebaiQA @AureRita