Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a display hook in the address step #92

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Add a display hook in the address step #92

merged 1 commit into from
Dec 28, 2022

Conversation

Amit-Kumar-Tiwari-Webkul
Copy link
Contributor

@Amit-Kumar-Tiwari-Webkul Amit-Kumar-Tiwari-Webkul commented Dec 24, 2022

Questions Answers
Description? There is no possibility to add something (message) on address step of checkout. So we suggest please add a display hook in the address step also just like other checkout steps.
Type? new feature
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#30666
How to test?
Possible impacts? Please indicate what parts of the software we need to check to make sure everything is alright.

@kpodemski kpodemski added the Waiting for QA Status: Waiting for QA feedback label Dec 27, 2022
@HanaRebaiQA HanaRebaiQA added Waiting for author and removed Waiting for QA Status: Waiting for QA feedback labels Dec 27, 2022
Copy link

@HanaRebaiQA HanaRebaiQA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this comment here

@MatShir
Copy link

MatShir commented Dec 28, 2022

LGTM ✅, you can test it @HanaRebaiQA.
Don't hesitate to ping at https://github.com/orgs/PrestaShop/teams/product-team and on slack #project-member so we can quickly reply ;)

@MatShir MatShir added Waiting for QA Status: Waiting for QA feedback and removed Waiting for author labels Dec 28, 2022
@HanaRebaiQA HanaRebaiQA self-assigned this Dec 28, 2022
Copy link

@HanaRebaiQA HanaRebaiQA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Amit-Kumar-Tiwari-Webkul

This PR is validated too PrestaShop/PrestaShop#30667 (review)

Thank You!

@HanaRebaiQA HanaRebaiQA added QA ✔️ Status: QA-Approved and removed Waiting for QA Status: Waiting for QA feedback labels Dec 28, 2022
@kpodemski kpodemski added this to the 2.1.0 milestone Dec 28, 2022
@kpodemski kpodemski merged commit 2e7020c into PrestaShop:develop Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA ✔️ Status: QA-Approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a display hook in the address step just like other checkout step
4 participants