Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block for checkout footer copyright_link #94

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

jdaandersj
Copy link
Contributor

Put the checkout copyright link into a block for easier child theme workflow.

Questions Answers
Description? Putting the copyright link on the checkout templates footer into a block to enable easier child theme override (matching the main store template footer)
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? Install theme, rebuild from templates, ensure checkout footer is not broken. Extra testing if desired: verify using the block in a child theme works.
Possible impacts? Should only impact the footer on 'checkout' pages

Put the checkout copyright link into a block for easier child theme workflow.
Copy link

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense but not sure if we can push it to QA without an issue, wdyt @PrestaShop/prestashop-maintainers ?

@kpodemski kpodemski added the Waiting for QA Status: Waiting for QA feedback label Jan 2, 2023
@kpodemski
Copy link
Contributor

@NeOMakinG I think so, it's pretty straightforward to test the PR

@AureRita
Copy link

AureRita commented Jan 3, 2023

Hi @jdaandersj

You can create a feature request just here,

PM can validate it

Thank you,

@Hlavtox
Copy link
Contributor

Hlavtox commented Jan 3, 2023

@AureRita This does not need PM approval, it's fixing a missing block, which is present in the other footer - https://github.com/PrestaShop/classic-theme/blob/develop/templates/_partials/footer.tpl.

@MhiriFaten MhiriFaten self-assigned this Jan 4, 2023
Copy link

@MhiriFaten MhiriFaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jdaandersj ,

It's QA approved ✔️

Thank you.

@MhiriFaten MhiriFaten added QA ✔️ Status: QA-Approved and removed Waiting for QA Status: Waiting for QA feedback labels Jan 5, 2023
@MhiriFaten MhiriFaten removed their assignment Jan 5, 2023
@Hlavtox Hlavtox merged commit 2569c01 into PrestaShop:develop Jan 5, 2023
@Hlavtox
Copy link
Contributor

Hlavtox commented Jan 5, 2023

Thanks @jdaandersj!

@matks matks added this to the 2.1.0 milestone Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA ✔️ Status: QA-Approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants