Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more suitable phrase for sort list #95

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Use more suitable phrase for sort list #95

merged 1 commit into from
Jan 13, 2023

Conversation

SharakPL
Copy link
Contributor

@SharakPL SharakPL commented Jan 5, 2023

Questions Answers
Description? Select isn't the best term when it comes to choosing from the list.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? no need
How to test? -
Possible impacts? -

@kpodemski kpodemski added this to the 2.0.8 milestone Jan 6, 2023
@kpodemski kpodemski merged commit f5409b9 into PrestaShop:develop Jan 13, 2023
@kpodemski
Copy link
Contributor

I approved and merged. We have the translation for other languages, and the previous phrase was too ambiguous in Polish and some other languages.

@kpodemski
Copy link
Contributor

Thanks @SharakPL

@matks matks modified the milestones: 2.0.8, 2.1.0 Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x346e3730 0x346e3730 0x346e3730 approved these changes

@kpodemski kpodemski kpodemski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SharakPL @kpodemski @0x346e3730 @matks