Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue when multiple password fields exists in page #98

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Fix issue when multiple password fields exists in page #98

merged 1 commit into from
Jan 23, 2023

Conversation

mflasquin
Copy link
Contributor

Questions Answers
Description? Fix issue when multiple password fields exists in page
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #30367
How to test? See PrestaShop/PrestaShop#30367

jolelievre
jolelievre approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mflasquin

@mflasquin mflasquin added the Waiting for QA Status: Waiting for QA feedback label Jan 22, 2023
@sallemiines sallemiines self-assigned this Jan 23, 2023
@sallemiines
Copy link

Hello @mflasquin

Thanx for the PR ! LGTM QA ✔️

Capture-d’écran-de-2023-01-23-11-50-03-png-3840×1080-

Capture-d’écran-de-2023-01-23-11-49-46-png-3840×1080-

Capture-d’écran-de-2023-01-23-11-49-04-png-3840×1080-

Thank you ! 🚀

@sallemiines sallemiines added QA ✔️ Status: QA-Approved and removed Waiting for QA Status: Waiting for QA feedback labels Jan 23, 2023
@mflasquin
Copy link
Contributor Author

Thanks @sallemiines 😄

@mflasquin mflasquin merged commit 3b23c8d into PrestaShop:develop Jan 23, 2023
@matks matks added this to the 2.1.0 milestone Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolelievre jolelievre jolelievre approved these changes

@NeOMakinG NeOMakinG Awaiting requested review from NeOMakinG

Assignees

@sallemiines sallemiines

Labels
QA ✔️ Status: QA-Approved
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

New password policy on customer acccount page "Your personal information, The PrestaShop 8.
4 participants
@mflasquin @sallemiines @jolelievre @matks